Skip to content

BE-838: Restore Atlas package startup after CLI gating - #9616

Closed
kostandinang wants to merge 1 commit into
mainfrom
kostandin/fix-atlas-start-cli-feature
Closed

BE-838: Restore Atlas package startup after CLI gating#9616
kostandinang wants to merge 1 commit into
mainfrom
kostandin/fix-atlas-start-cli-feature

Conversation

@kostandinang

@kostandinang kostandinang commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Restore the Atlas package's start script after the Atlas binary was gated behind the cli feature. Without this, callers such as benchmark setup fail before Atlas starts, including the base comparison for #9585.

🔗 Related links

🚫 Blocked by

  • Nothing

🔍 What does this change?

  • Passes --features cli when the @rust/hash-graph-atlas start script invokes Cargo.
🏗️ Agent notes

The Atlas binary declares required-features = ["cli"]. The package script omitted that feature, so Cargo exited with target requires the features: cli and the benchmark harness later reported a healthcheck timeout.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

None.

🐾 Next steps

Rerun the benchmark check on #9585 after this reaches main so its baseline checkout includes the repaired script.

🛡 What tests cover this?

  • Invoked the package start script with --help; Cargo built and ran the Atlas CLI successfully.
  • Pre-commit checks passed, including package formatting and task-dependency validation.

❓ How to test this?

  1. Run mise exec -- yarn workspace @rust/hash-graph-atlas start --help.
  2. Confirm Cargo builds the Atlas binary and prints its command-line help instead of reporting a missing cli feature.

📹 Demo

Not applicable; this repairs an internal start command.

Made with Cursor

@vercel

vercel Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Sep 9, 2026 8:21am UTC
3 Skipped Deployments
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Sep 9, 2026 8:21am UTC
petrinaut Skipped Skipped Sep 9, 2026 8:21am UTC
petrinaut-docs Skipped Skipped Sep 9, 2026 8:21am UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – petrinaut September 9, 2026 08:10 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs September 9, 2026 08:10 Inactive
@github-actions github-actions Bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Sep 9, 2026
@kostandinang kostandinang changed the title Enable Atlas CLI feature in the start script BE-838: Restore Atlas package startup after CLI gating Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.93%. Comparing base (04db878) to head (d60308f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9616      +/-   ##
==========================================
- Coverage   65.93%   65.93%   -0.01%     
==========================================
  Files        1886     1886              
  Lines      198341   198341              
  Branches     8236     8236              
==========================================
- Hits       130772   130771       -1     
  Misses      66039    66039              
- Partials     1530     1531       +1
Flag Coverage Δ
apps.hash-graph 12.54% <ø> (ø)
rust.hash-graph-atlas 80.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kostandinang

kostandinang commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@indietyp This issue was created while fixing #9585’s checks.

Cause:

Posting for confirmation: is this a relevant fix, or should the PR be closed?

@TimDiekmann

TimDiekmann commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR won't fix it as atlas requires a subcommand. I'm going to open a fix shortly.

@TimDiekmann TimDiekmann closed this Sep 9, 2026
@TimDiekmann
TimDiekmann deleted the kostandin/fix-atlas-start-cli-feature branch September 9, 2026 16:27
@claude claude Bot mentioned this pull request Sep 9, 2026
Merged
4 tasks
@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Closing in favour of #9633 (BE-841). Adding --features cli clears the cargo error, but the binary then exits with a usage error because it needs a subcommand, and the benches don't need the atlas binary at all, so the start script is removed instead and the bench workflow only starts @apps/hash-graph. Decided with Tim in Slack.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indietyp indietyp Awaiting requested review from indietyp

Assignees

@kostandinang kostandinang

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kostandinang @TimDiekmann